Apache vhost bug (patch included)

[Jan-Pascal van Best]

Hi Sean and others,

I'm using the svn version of webapps-common (rev. 109) for the packaging
of phpesp (Bug#421268). I've found that the apache-vhost option creates
wrong Apache config files: the vhost name should be given in a ServerName
directive, not in the <VirtualHost> tag. The current config file breaks
all Apache vhosts :-(

See patch

By the way, thanks for the good work on webapps-common. It makes my life
as a packager a lot easier. Any ideas as to when it will be released into
Debian?

Cheers

Jan-Pascal


--- templates/apache-virtualhost.conf (revision 109)
+++ templates/apache-virtualhost.conf (working copy)
@@ -1,3 +1,4 @@
-<VirtualHost _WC_VHOST_>
+<VirtualHost *>
+ ServerName _WC_VHOST_
Include /etc/webapps-common/apps-enabled/_WC_HTTPD_/_WC_VHOST_/*.conf
</VirtualHost>

[Stephen Gran]

Post by Jan-Pascal van Best
Hi Sean and others,
I'm using the svn version of webapps-common (rev. 109) for the packaging
of phpesp (Bug#421268). I've found that the apache-vhost option creates
wrong Apache config files: the vhost name should be given in a ServerName
directive, not in the <VirtualHost> tag. The current config file breaks
all Apache vhosts :-(
See patch
By the way, thanks for the good work on webapps-common. It makes my life
as a packager a lot easier. Any ideas as to when it will be released into
Debian?
Cheers
Jan-Pascal
--- templates/apache-virtualhost.conf (revision 109)
+++ templates/apache-virtualhost.conf (working copy)
@@ -1,3 +1,4 @@
-<VirtualHost _WC_VHOST_>
+<VirtualHost *>
+ ServerName _WC_VHOST_
Include /etc/webapps-common/apps-enabled/_WC_HTTPD_/_WC_VHOST_/*.conf
</VirtualHost>

<VirtualHost *> is certainly wrong in my environments. I tend to use
<VirtualHost 1.2.3.4:80> type declarations. Can we perhaps make this
configurable instead? Sean, if you are busy, I can try to take a look
over the weekend.

[sean finney]

Post by Stephen Gran
<VirtualHost *> is certainly wrong in my environments. I tend to use
<VirtualHost 1.2.3.4:80> type declarations. Can we perhaps make this
configurable instead? Sean, if you are busy, I can try to take a look
over the weekend.

hrm... what might be the best thing to do here is move the template file
out of /usr/share and somewhere under /etc, so that it becomes
user-editable for stuff like this. this would also make it easier to
customize other useful stuff like logging destinations, etc. what do
you think?



sean

[Stephen Gran]

Post by sean finney

Post by Stephen Gran
<VirtualHost *> is certainly wrong in my environments. I tend to use
<VirtualHost 1.2.3.4:80> type declarations. Can we perhaps make this
configurable instead? Sean, if you are busy, I can try to take a look
over the weekend.

hrm... what might be the best thing to do here is move the template file
out of /usr/share and somewhere under /etc, so that it becomes
user-editable for stuff like this. this would also make it easier to
customize other useful stuff like logging destinations, etc. what do
you think?

That was exactly my feeling, in fact. I'm not sure yet how I would go
about passing an IP to the template (last time I looked, there was no
way) but just having this stuff started on would be good.

[sean finney]

hey jan-pascal,

Post by Jan-Pascal van Best
I'm using the svn version of webapps-common (rev. 109) for the packaging
of phpesp (Bug#421268). I've found that the apache-vhost option creates
wrong Apache config files: the vhost name should be given in a ServerName
directive, not in the <VirtualHost> tag. The current config file breaks
all Apache vhosts :-(

hey, cool! thanks for catching this.

Post by Jan-Pascal van Best
See patch
By the way, thanks for the good work on webapps-common. It makes my life
as a packager a lot easier. Any ideas as to when it will be released into
Debian?

i keep saying "this weekend will be the weekend i get to work on
webapps-common", and things just keep coming up elsewhere sucking away
my time (i.e. the recent month of php bugs, unghh...).

i can say at the very latest i plan to have something uploaded to
unstable during or after debconf, when i should have a nice solid chunk
of continuous time to work on stuff like this. and it seems this
weekend i have some free time too, let's see how that turns out :)


sean