RFS: sqlbuddy

[Medhamsh]

Dear mentors,

I am looking for a sponsor for my package "sqlbuddy".

* Package name : sqlbuddy
Version : 1.3.3-1
Upstream Author : Calvin Lough
* URL : http://www.sqlbuddy.com
* License : MIT
Section : web

It builds those binary packages:

sqlbuddy - Web based MySQL administration

To access further information about this package, please visit the
following URL:

http://mentors.debian.net/package/sqlbuddy

Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/s/sqlbuddy/sqlbuddy_1.3.3-1.dsc

I would be glad if someone uploaded this package for me.

Sincerely,

[Tanguy Ortolo]

Several remarks after a quick look.

debian/control:
* Homepage: There is an extra space after the website URL, better to
remove it. You could add the final / too, although that is not
required since all browser add it when it is missing, as far as I
know.
* Vcs-*: You should remove the commented Vcs-* fields, or update them
and uncomment them if you are using a public VCS for maintaining that
package (which would be a good thing, by the way).
* Description: SQLite it the correct capitalization, not sqlite.

debian/rules: I am curious, is there a reason why you did not use
catchall-style shore dh7 rules?

debian/watch: The upstream release practice prevents you to have a watch
file indeed, I think you should ask them if they could publish
versionned tarballs.

There is also the empty /usr/share/sqlbuddy/exports/ which is detected
by Lintian. I guess that is intentional, but if this is a directory
where database dumps will be placed, then it is at a wrong place, and it
should be under /var instead, with the appropriate configuration, patch
or symlink.

Again, that was just a quick look, I still have to give it a closer
look.
--
,--.
: /` ) Tanguy Ortolo <xmpp:***@ortolo.eu> <irc://irc.oftc.net/Tanguy>
| `-' Debian Developer
\_

[Medhamsh]

Hi,

Thanks a lot for a quick review.

Post by Tanguy Ortolo
* Homepage: There is an extra space after the website URL, better to

I will fix this.

Post by Tanguy Ortolo
should remove the commented Vcs-* fields, or update them and uncomment
them if you are using a public VCS for maintaining that package (which
would be a good thing, by the way). * Description: SQLite it the correct
capitalization, not sqlite.

Ya. I have a VCS repo at gitorious.org. I am a beginner in packaging
and dont know the proper way of maintaining packages under VCS. Would
be happy if someone shows some best practices. Eventually I will adapt
once I have more than 5-6 packages to maintain.

Post by Tanguy Ortolo
debian/rules: I am curious, is there a reason why you did not use
catchall-style shore dh7 rules?

Since this is my first package, I thought I would learn and remember better
if I write them all and also catchall style appeared magical and advanced to
me. May be I have to adapt it soon?

Post by Tanguy Ortolo
debian/watch: The upstream release practice prevents you to have a watch
file indeed, I think you should ask them if they could publish versionned
tarballs.

I was really struck here. Tried several times with all regexps but couldn't
succeed. I could find out a github page for the project.

https://github.com/calvinlough/sqlbuddy

Can I use http://githubredir.debian.net/ for generating the watch file.

Post by Tanguy Ortolo
There is also the empty /usr/share/sqlbuddy/exports/ which is detected
by Lintian. I guess that is intentional, but if this is a directory where
database dumps will be placed, then it is at a wrong place, and it should
be under /var instead, with the appropriate configuration, patch or
symlink.

Are there any additional flags while using lintian? Because, many of the
errors were not detected by lintian in my computer. I came to know them
only when I uploaded to the mentors.

Post by Tanguy Ortolo
Again, that was just a quick look, I still have to give it a closer
look.

And one more doubt. Can I just make the changes you suggested and re-upload
the package to the mentors with the same package version?

Sincerely,

[Tanguy Ortolo]

Post by Medhamsh
Ya. I have a VCS repo at gitorious.org. I am a beginner in packaging
and dont know the proper way of maintaining packages under VCS. Would
be happy if someone shows some best practices. Eventually I will adapt
once I have more than 5-6 packages to maintain.

I think the most common practice for packaging with Git is to store all
the package directory, containing the original sources and the debian/
directory. Have an “upstream” branch tracking upstream releases, from
the released tarballs or possibly from the upstream version control as
long as it matches the tarball content. Tag upstream releases as
“upstream/version”. Have a “master” branch, derived from the “upstream”
one, with your Debian work on it. Tag Debian revisions as
“debian/version-revision” when they are uploaded to Debian (to the
Debian archive I mean, not to mentors). If you have patches against the
upstream version, store your work under Git with patches unapplied.

And finally, indicate the URLs of your VCS in the Vcs-* control fields.

Post by Medhamsh

Post by Tanguy Ortolo
debian/rules: I am curious, is there a reason why you did not use
catchall-style shore dh7 rules?

Since this is my first package, I thought I would learn and remember better
if I write them all and also catchall style appeared magical and advanced to
me. May be I have to adapt it soon?

Personally, I think that should be your choice. I use dh7 short style
but I have nothing against other styles.

Post by Medhamsh

Post by Tanguy Ortolo
debian/watch: The upstream release practice prevents you to have a watch
file indeed, I think you should ask them if they could publish versionned
tarballs.

I was really struck here. Tried several times with all regexps but couldn't
succeed. I could find out a github page for the project.
https://github.com/calvinlough/sqlbuddy
Can I use http://githubredir.debian.net/ for generating the watch file.

I think you can, since you need repacking the upstream ZIP archives
anyway, so you could as well use some Github-generated tarballs. As long
as their content match the upstream released ZIP archives.

Post by Medhamsh

Post by Tanguy Ortolo
There is also the empty /usr/share/sqlbuddy/exports/ which is detected
by Lintian. I guess that is intentional, but if this is a directory where
database dumps will be placed, then it is at a wrong place, and it should
be under /var instead, with the appropriate configuration, patch or
symlink.

Are there any additional flags while using lintian? Because, many of the
errors were not detected by lintian in my computer. I came to know them
only when I uploaded to the mentors.

Yes, Lintian has several levels of information, and that one was
informative, in other words not a real problem by itself. Some options
you can try: --color, --display-experimental, --info, --display-info,
--pedantic.

Post by Medhamsh
And one more doubt. Can I just make the changes you suggested and re-upload
the package to the mentors with the same package version?

The version only has to be changed if there are regular users already
using the current one. Since mentors is not a common binary repository,
that is not the case, so you can use the same version number.
--
,--.
: /` ) Tanguy Ortolo <xmpp:***@ortolo.eu> <irc://irc.oftc.net/Tanguy>
| `-' Debian Developer
\_

[Medhamsh]

Hi,

I have done possible changes. Hoping for more help.

Post by Tanguy Ortolo
* Homepage: There is an extra space after the website URL, better to
remove it. You could add the final / too, although that is not required

Fixed this.

Post by Tanguy Ortolo
should remove the commented Vcs-* fields, or update them and uncomment
them if you are using a public VCS for maintaining that package (which
would be a good thing, by the way). * Description: SQLite it the correct
capitalization, not sqlite.

Using gitorious for packaging. I hope this shouldn't be a problem. Can I
use collabmaint? Is it OK for such small packages? Also fixed the case
of SQLite.

Post by Tanguy Ortolo
debian/watch: The upstream release practice prevents you to have a watch
file indeed, I think you should ask them if they could publish versionned
tarballs.

I have put a mail and awaiting reply. For now using a commented watch file.

Post by Tanguy Ortolo
There is also the empty /usr/share/sqlbuddy/exports/ which is detected
by Lintian. I guess that is intentional, but if this is a directory where
database dumps will be placed, then it is at a wrong place, and it should
be under /var instead, with the appropriate configuration, patch or
symlink.

Fixed this by linking to /var/lib/sqlbuddy

Sincerely,

[harish badrinath]

Post by Medhamsh
Hi,
I have done possible changes. Hoping for more help.

Hello,

DISCLAIMER:
I don't know if i am supposed to "review" packages since
(a)I cant upload to debian.
(b)I myself am a maintainer of just one package :).
My intention is to help out.

My "review" consists of auditing the submitted proposed package only for
trailing spaces and empty lines. This is mainly because
lintian -IiE --pedantic sqlbuddy_1.3.3-1_all.deb sqlbuddy_1.3.3-1_i386.changes

complains, only about a missing changelog.
Upstream does not seem to ship a changelog with the distribution
tarball/zip file.


File: debian/changelog:Trailing space in line 3
File: debian/control:Empty lines from 19-21
File: debian/copyright: Trailing spaces in lines 18-22,25,26,29-34

Regards,
Harish Badrinath

[Medhamsh]

Hello,

complains, only about a missing changelog. Upstream does not seem to ship
a changelog with the distribution tarball/zip file.

There seems a changelog in the upstream's website though they dont
ship it in the tarball at the following location.

http://sqlbuddy.com/releasenotes

Tried to patch the changelog file. Though lintian at my end dint spot
out the error, the page at mentors gave out the following warning

W:sqlbuddy source:format-3.0-but-debian-changes-patch

Is this OK? Do I have any work around?

File: debian/changelog:Trailing space in line 3
File: debian/control:Empty lines from 19-21
File: debian/copyright: Trailing spaces in lines 18-22,25,26,29-34

Fixed all these trailing space issues.

Sincerely,

[Tanguy Ortolo]

Post by Medhamsh
There seems a changelog in the upstream's website though they dont
ship it in the tarball at the following location.
http://sqlbuddy.com/releasenotes
Tried to patch the changelog file. Though lintian at my end dint spot
out the error, the page at mentors gave out the following warning
W:sqlbuddy source:format-3.0-but-debian-changes-patch
Is this OK? Do I have any work around?

If the upstream changelog is not part of the source and you want to
include it in your package, you should store it under your debian/
directory. All the remaining should be files from the tarball, possibly
patched by the means of quilt patches.
--
,--.
: /` ) Tanguy Ortolo <xmpp:***@ortolo.eu> <irc://irc.oftc.net/Tanguy>
| `-' Debian Developer
\_

[Medhamsh]

Hi,

Post by Tanguy Ortolo
If the upstream changelog is not part of the source and you want to
include it in your package, you should store it under your debian/
directory. All the remaining should be files from the tarball, possibly
patched by the means of quilt patches.

Just store it directly under debian/ dir and put it in docs? What flags
should be used for dh_installchangelogs?

Sincerely,

[Tanguy Ortolo]

Post by Medhamsh
Just store it directly under debian/ dir and put it in docs?

No, rather use dh_installchangelogs.

Post by Medhamsh
What flags should be used for dh_installchangelogs?

Give it the changelog name as argument, for instance:
dh_installchangelogs debian/changelog.upstream
--
,--.
: /` ) Tanguy Ortolo <xmpp:***@ortolo.eu> <irc://irc.oftc.net/Tanguy>
| `-' Debian Developer
\_

[Medhamsh]

Hello,

Post by Tanguy Ortolo
dh_installchangelogs debian/changelog.upstream

Worked like a charm. Uploaded to mentors again.

Sincerely,

[Medhamsh]

Hello,

Are there any other inputs for this package? The only
issue is with watch file.

Post by harish badrinath
Hello,

Post by Tanguy Ortolo
dh_installchangelogs debian/changelog.upstream

Worked like a charm. Uploaded to mentors again.

Sincerely,

[harish badrinath]

Hello,

Post by harish badrinath
Hello,

complains, only about a missing changelog. Upstream does not seem to ship
a changelog with the distribution tarball/zip file.

There seems a changelog in the upstream's website though they dont
ship it in the tarball at the following location.
http://sqlbuddy.com/releasenotes
Tried to patch the changelog file. Though lintian at my end dint spot
out the error, the page at mentors gave out the following warning
W:sqlbuddy source:format-3.0-but-debian-changes-patch

I think its because you have a patch named debian-changes-* (I am not sure).

Renaming it to something more descriptive, should make the warning go
away AFAIK.


Regards,
Harish Badrinath

[harish badrinath]

Hello,

Sorry, i was unfortunately wrong. I also apologize for the unnecessary
traffic on 2 mailing lists and to one contributor.

Harish



On Thu, Jan 26, 2012 at 8:09 PM, harish badrinath

Post by harish badrinath
Hello,

Post by harish badrinath
Hello,

complains, only about a missing changelog. Upstream does not seem to ship
a changelog with the distribution tarball/zip file.

There seems a changelog in the upstream's website though they dont
ship it in the tarball at the following location.
http://sqlbuddy.com/releasenotes
Tried to patch the changelog file. Though lintian at my end dint spot
out the error, the page at mentors gave out the following warning
W:sqlbuddy source:format-3.0-but-debian-changes-patch

I think its because you have a patch named debian-changes-* (I am not sure).
Renaming it to something more descriptive, should make the warning go
away AFAIK.
Regards,
Harish Badrinath